Fixed issue with skipping over self & source generated by another instance #12495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6a59e4c:
|
|
Can you add a test? Maybe with manually written |
Andarist
force-pushed
the
fix/skipping-over-jsx-self-source
branch
from
cebf9d4
to
6a59e4c
Compare
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/35062/ |
|
Oh, ive added it - just havent pushed out. |
nicolo-ribaudo
approved these changes
Dec 12, 2020
nicolo-ribaudo
added
PR: Bug Fix 🐛
existentialism
approved these changes
Dec 12, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue reported here #12253 (comment) and here emotion-js/emotion#2173
Basically the issue is that its fairly easy to add the same plugin with different options through presets and in this case the React preset has been adding those props but thr Emotion preset has started skipping over them because it was not configured with a development flag - this was a behavioral change after switching to the -experimental builder completely