Setup JSX runtime even if the file doesn't contain JSX #12479
Conversation
nicolo-ribaudo
added
PR: Bug Fix 🐛
| @@ -0,0 +1 @@ | |||
| const foo = /*#__PURE__*/undefined.jsx("p", {}); | |||
There was a problem hiding this comment.
This is a different unrelated bug: #12467
I'm preparing another PR for it, but it's lower priority since it's not a regression.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/34726/ |
|
Btw, we have this test that ensures that even if we are always setting up the runtime, we don't inject it when it's not needed: https://github.com/babel/babel/tree/main/packages/babel-plugin-transform-react-jsx/test/fixtures/nextAutoImport/no-jsx |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2cbe36d:
|
| @@ -138,136 +138,134 @@ You can set \`throwIfNamespace: false\` to bypass this warning.`, | |||
|
|
|||
| Program: { | |||
| enter(path, state) { | |||
| if (hasJSX(path)) { | |||
There was a problem hiding this comment.
I'm assuming the reason why this was done originally was for performance? And that there aren't plugins that convert non-jsx stuff but that I guess isn't the case then
There was a problem hiding this comment.
Yeah probably for performance, but doing a deep traversal to check if there is JSX isn't going to be fast anyway.
There was a problem hiding this comment.
Makes me think this sort of thing shouldn't need to be set every file if it's the same for all of them (for the most part unless you use comments or overrides)?
There was a problem hiding this comment.
Yeah, usually you just set it once in the config file.
github-actions
bot
added
the
outdated
Please review with whitespaces diff off