Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the old JSX builder with the one that has been used experimentally #12465

Closed
wants to merge 1 commit into from

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented Dec 9, 2020

Q                       A
Fixed Issues? N/A
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This is just a followup to #12253 . That other PR has switched over to using the -experimental package so the old one became completely unused. In this PR I have just removed the old & and unused builder and replaced it with the -experimental one.

@Andarist Andarist added PR: Internal 🏠 A type of pull request used for our changelog categories area: react area: jsx labels Dec 9, 2020
@Andarist Andarist force-pushed the mark-experimental-jsx-builder-as-stable branch from 565d2c2 to 8790910 Compare December 9, 2020 12:29
@babel-bot
Copy link
Collaborator

babel-bot commented Dec 9, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/34407/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8790910:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@Andarist Andarist force-pushed the mark-experimental-jsx-builder-as-stable branch from 8790910 to 876d898 Compare December 9, 2020 12:43
@Andarist
Copy link
Member Author

Andarist commented Dec 9, 2020

I've missed that the old helper is still used by @babel/plugin-transform-react-jsx-compat and @babel/plugin-transform-react-inline-elements. It seems that this should be cleaned up at a later point in time because I'm not even sure if you want to keep supporting -compat transform.

@Andarist Andarist closed this Dec 9, 2020
@Andarist Andarist deleted the mark-experimental-jsx-builder-as-stable branch December 9, 2020 13:29
@nicolo-ribaudo
Copy link
Member

Yeah @babel/plugin-transform-react-jsx-compat has only 222 downloads/week, we can probably deprecate and archive it.

@Andarist
Copy link
Member Author

Andarist commented Dec 9, 2020

It would probably be easiest to just drop it when releasing Babel 8. There were also tests failing for the @babel/plugin-transform-react-inline-elements but I don't have time to investigate this right now.

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Mar 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: jsx area: react outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants