Recover from "missing semicolon" errors #12437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: Polish 💅
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/39074/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cf0aef0:
|
|
Can you rebase on #12375 ? So we are confident that it also works when |
nicolo-ribaudo
force-pushed
the
error-recovery-missing-semicolons
branch
3 times, most recently
from
70ad6f1
to
c7d1b7e
Compare
JLHwung
reviewed
Dec 3, 2020
...r/test/fixtures/es2017/async-functions/invalid-escape-export-dflt-async-function/output.json
Outdated
Show resolved
Hide resolved
JLHwung
reviewed
Dec 3, 2020
...l-parser/test/fixtures/es2017/async-functions/invalid-escape-sequence-function-list/input.js
Outdated
Show resolved
Hide resolved
JLHwung
approved these changes
Dec 14, 2020
nicolo-ribaudo
force-pushed
the
error-recovery-missing-semicolons
branch
from
44ac956
to
cf0aef0
Compare
sosukesuzuki
approved these changes
Feb 1, 2021
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original motivation for this PR was to prevent throwing in #12436, but then I realized that this is an error that it's really easy to recover from.
Unexpected token, expected \";\"and now they throw a similarly unuseful error (adding;was not the necessary fix in these fixtures).