New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ts]Fix syntax error for modifier name class methods with type parameters #12356
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
ffa7f50
Fix syntax error for modifier name class methods with type parameters
sosukesuzuki f4fba0b
Address reviewed points
sosukesuzuki 7fdfb6b
Add test and update allowlist for modifer name parameters
sosukesuzuki 92f8321
Modify to avoid syntax error related to ASI
sosukesuzuki File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
4 changes: 4 additions & 0 deletions
4
packages/babel-parser/test/fixtures/typescript/class/modifier-name-parameters/input.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| class Foo { | ||
| constructor(private, public, static) { | ||
| } | ||
| } | ||
67 changes: 67 additions & 0 deletions
67
packages/babel-parser/test/fixtures/typescript/class/modifier-name-parameters/output.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| { | ||
| "type": "File", | ||
| "start":0,"end":58,"loc":{"start":{"line":1,"column":0},"end":{"line":4,"column":1}}, | ||
| "program": { | ||
| "type": "Program", | ||
| "start":0,"end":58,"loc":{"start":{"line":1,"column":0},"end":{"line":4,"column":1}}, | ||
| "sourceType": "module", | ||
| "interpreter": null, | ||
| "body": [ | ||
| { | ||
| "type": "ClassDeclaration", | ||
| "start":0,"end":58,"loc":{"start":{"line":1,"column":0},"end":{"line":4,"column":1}}, | ||
| "id": { | ||
| "type": "Identifier", | ||
| "start":6,"end":9,"loc":{"start":{"line":1,"column":6},"end":{"line":1,"column":9},"identifierName":"Foo"}, | ||
| "name": "Foo" | ||
| }, | ||
| "superClass": null, | ||
| "body": { | ||
| "type": "ClassBody", | ||
| "start":10,"end":58,"loc":{"start":{"line":1,"column":10},"end":{"line":4,"column":1}}, | ||
| "body": [ | ||
| { | ||
| "type": "ClassMethod", | ||
| "start":14,"end":56,"loc":{"start":{"line":2,"column":2},"end":{"line":3,"column":3}}, | ||
| "static": false, | ||
| "key": { | ||
| "type": "Identifier", | ||
| "start":14,"end":25,"loc":{"start":{"line":2,"column":2},"end":{"line":2,"column":13},"identifierName":"constructor"}, | ||
| "name": "constructor" | ||
| }, | ||
| "computed": false, | ||
| "kind": "constructor", | ||
| "id": null, | ||
| "generator": false, | ||
| "async": false, | ||
| "params": [ | ||
| { | ||
| "type": "Identifier", | ||
| "start":26,"end":33,"loc":{"start":{"line":2,"column":14},"end":{"line":2,"column":21},"identifierName":"private"}, | ||
| "name": "private" | ||
| }, | ||
| { | ||
| "type": "Identifier", | ||
| "start":35,"end":41,"loc":{"start":{"line":2,"column":23},"end":{"line":2,"column":29},"identifierName":"public"}, | ||
| "name": "public" | ||
| }, | ||
| { | ||
| "type": "Identifier", | ||
| "start":43,"end":49,"loc":{"start":{"line":2,"column":31},"end":{"line":2,"column":37},"identifierName":"static"}, | ||
| "name": "static" | ||
| } | ||
| ], | ||
| "body": { | ||
| "type": "BlockStatement", | ||
| "start":51,"end":56,"loc":{"start":{"line":2,"column":39},"end":{"line":3,"column":3}}, | ||
| "body": [], | ||
| "directives": [] | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| ], | ||
| "directives": [] | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be an error, because
private,publicandstaticare reserved words in strict mode.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
babel-parserdoesn't check reserved word for TypeScript?babel/packages/babel-parser/src/plugins/typescript/index.js
Lines 1962 to 1972 in b564368
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right, I didn't remember about that.