Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: correctly transform this.#m?.(...arguments) #12350

Merged
merged 3 commits into from Nov 16, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Nov 11, 2020

Q                       A
Fixed Issues? The transpiled output of new class { #m; constructor() { this.#m?.(...arguments) } } throws (REPL)
Patch: Bug Fix? Yes
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Also added a Jest powered fixture tester for helpers. It will be great if the fixture test runner could support inlining input/output/options.

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Optional Chaining labels Nov 11, 2020
@babel-bot
Copy link
Collaborator

babel-bot commented Nov 11, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/32518/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 11, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b783079:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@JLHwung JLHwung merged commit f54f1ee into babel:main Nov 16, 2020
@JLHwung JLHwung deleted the fix-helper-optimise-call-expression branch November 16, 2020 15:16
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 16, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Optional Chaining
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants