Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the correct context when re-using a cached NodePath #12331

Merged
merged 2 commits into from Nov 10, 2020
Merged

Use the correct context when re-using a cached NodePath #12331

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
423a4c5
Use the correct `context` when re-using a cached path from a differen…
nicolo-ribaudo Nov 7, 2020
e7ce1ba
Skip test with older Babel versions
nicolo-ribaudo Nov 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions scripts/integration-tests/e2e-babel-old-version.sh
View file
Open in desktop
Expand Up @@ -43,6 +43,10 @@ node "$PWD"/scripts/integration-tests/utils/bump-babel-dependencies.js
fs.writeFileSync('./package.json', JSON.stringify(pkg, null, 2));
"

# https://github.com/babel/babel/pull/12331 - This test is fixed in @babel/traverse 7.12.7,
# so it will fail with older versions. We can disable it.
(cd packages/babel-plugin-transform-modules-systemjs/test/fixtures/regression/; mv issue-12329 .issue-12329)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about supporting minBabelVersion in fixture runner 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only if this problem comes up more than once 😛


# Update deps, build and test
rm yarn.lock
make -j test-ci
Expand Down