Handle exprAllowed before ObjectLike is parsed #12267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Bug Fix 🐛
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/31260/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 811ac29:
|
nicolo-ribaudo
approved these changes
Oct 27, 2020
sosukesuzuki
added a commit
to prettier/prettier
that referenced
this pull request
Nov 6, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes 2 commits. The first commits fixes #11353 by correctly handling
exprAllowed.Currently we use braceIsBlock to determine whether
{starts an object literal or a blocked statement. However, this approach can not differentiate0 ? a : {}toa : {}because we do not track ternary in token context. Thus we incorrectly classify{}as a statement block here.This PR fixes it on the parser level. It is not ideal but I think it is difficult to track it in tokenizing level performantly.
The second commit is to avoid accessing
this.prodParamin token context update, because of the timing issues.