Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reset EndLocation for catch param #11943

Merged
merged 1 commit into from Aug 10, 2020
Merged

fix: reset EndLocation for catch param #11943

merged 1 commit into from Aug 10, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Aug 10, 2020 •
edited by gitpod-io bot

Q                       A
Fixed Issues? Fixes #11939
Patch: Bug Fix? Yes
Tests Added + Pass? Yes
License MIT

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: parser area: typescript labels Aug 10, 2020
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/27141/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cf7b0a3:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@JLHwung JLHwung merged commit 008fe25 into babel:main Aug 10, 2020
@JLHwung JLHwung deleted the fix-11939 branch August 10, 2020 21:06
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 10, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

Assignees
No one assigned
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[typescript] catch clause with type annotation location is incorrect
4 participants
@JLHwung @babel-bot @existentialism @kaicataldo