Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for ConfigItem being generated by another copy of Babel #11734

Merged
merged 8 commits into from Nov 10, 2020
Merged

Account for ConfigItem being generated by another copy of Babel #11734

Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a49e0d7
Account for ConfigItem being generated by another copy of Babel
developit Jun 19, 2020
c75a6f2
Use a symbol
developit Jun 23, 2020
96f4fe6
Use a symbol
developit Jun 23, 2020
04dc694
Update item.js
developit Jun 23, 2020
25508fc
Update packages/babel-core/src/config/item.js
nicolo-ribaudo Nov 9, 2020
c280263
Update packages/babel-core/src/config/item.js
nicolo-ribaudo Nov 9, 2020
93ca9c8
Update
nicolo-ribaudo Nov 9, 2020
a00bf9e
Fix flow
nicolo-ribaudo Nov 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 11 additions & 1 deletion packages/babel-core/src/config/item.js
View file
Open in desktop
Expand Up @@ -40,7 +40,7 @@ export function createConfigItem(
}

export function getItemDescriptor(item: mixed): UnloadedDescriptor | void {
if (item instanceof ConfigItem) {
if (item?.[CONFIG_ITEM_BRAND]) {
return item._descriptor;
}

Expand All @@ -49,6 +49,8 @@ export function getItemDescriptor(item: mixed): UnloadedDescriptor | void {

export type { ConfigItem };

const CONFIG_ITEM_BRAND = Symbol.for("@babel/core@7 - ConfigItem");

/**
* A public representation of a plugin/preset that will _eventually_ be load.
* Users can use this to interact with the results of a loaded Babel
Expand All @@ -64,6 +66,12 @@ class ConfigItem {
*/
_descriptor: UnloadedDescriptor;

// TODO(Babel 8): Check if this symbol needs to be updated
/**
nicolo-ribaudo marked this conversation as resolved.
Show resolved Hide resolved
* Used to detect ConfigItem instances from other Babel instances.
*/
[CONFIG_ITEM_BRAND] = true;

/**
* The resolved value of the item itself.
*/
Expand Down Expand Up @@ -105,6 +113,8 @@ class ConfigItem {
this._descriptor = descriptor;
Object.defineProperty(this, "_descriptor", { enumerable: false });

Object.defineProperty(this, CONFIG_ITEM_BRAND, { enumerable: false });

this.value = this._descriptor.value;
this.options = this._descriptor.options;
this.dirname = this._descriptor.dirname;
Expand Down