Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:added check for forXstatement pattern #11703

Merged
merged 6 commits into from Jun 12, 2020
Merged

fix:added check for forXstatement pattern #11703

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d4c0a5e
added check for forXstatement pattern
wlawt Jun 10, 2020
71f4c24
test case:check node left of for-of
wlawt Jun 10, 2020
79f5619
add node check from feedback
wlawt Jun 11, 2020
a45c4dc
add additional test cases & comment for-of & for-in
wlawt Jun 11, 2020
fff451b
Update packages/babel-helper-member-expression-to-functions/src/index.js
wlawt Jun 11, 2020
d07e916
Update packages/babel-helper-member-expression-to-functions/src/index.js
wlawt Jun 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/babel-helper-member-expression-to-functions/src/index.js
View file
Open in desktop
Expand Up @@ -337,6 +337,7 @@ const handle = {
// [MEMBER = _VALUE] = ARR -> [_destructureSet(MEMBER) = _VALUE] = ARR
// [...MEMBER] -> [..._destructureSet(MEMBER)]
if (
existentialism marked this conversation as resolved.
Show resolved Hide resolved
parentPath.isForXStatement() ||
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also check if node is the left of the ForXStatement. Consider this case

for (const el of this.#arr);

this.#x should not be transformed into _destructureSet(this, x).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright, just to clarify its 1st checking if its a for-of statement then checking if the next node is left of the for-of ?

// { KEY: MEMBER } = OBJ
(parentPath.isObjectProperty({ value: node }) &&
parentPath.parentPath.isObjectPattern()) ||
Expand Down