Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: split locationParser into ParserErrors and error message #11653

Merged
merged 1 commit into from May 30, 2020
Merged

refactor: split locationParser into ParserErrors and error message #11653

merged 1 commit into from May 30, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented May 30, 2020

Q                       A
License MIT

Rename packages/babel-parser/src/parser/location.js into error.js and extract error message templates into a dedicated file.

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label May 30, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 97409ed:

Sandbox Source
agitated-sound-2elgn Configuration
relaxed-goldwasser-ifbuj Configuration

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/23239/

@JLHwung
Copy link
Contributor Author

JLHwung commented May 30, 2020

@kaicataldo I think this change is related to https://github.com/babel/babel/pull/11376/files#diff-e4403a877d80de653400d88d85e4801aR72.

@kaicataldo
Copy link
Member

Yeah, will update it once this is merged!

@JLHwung JLHwung merged commit b5c4a46 into babel:master May 30, 2020
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 30, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JLHwung @babel-bot @kaicataldo @existentialism