Refine babel core types #11544
Merged
Refine babel core types #11544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Internal 🏠
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 369d237:
|
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/23973/ |
JLHwung
commented
May 12, 2020
nicolo-ribaudo
approved these changes
May 12, 2020
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
JLHwung
force-pushed
the
refine-babel-core-types
branch
from
01e9e44
to
369d237
Compare
|
I'm merging this with a single review, since it's mostly about internal typings. |
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@babel/core.packages/babel-core/src/config/validation/plugins.js, whichcatches a bug introduced by fix: pass optionLoc when validating plugin object #10402 where
assertVisitorMapis not working as intended.