Fix redeclaring private in nested class's superClass #11424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
force-pushed
the
nested-private-extends
branch
from
d67d321
to
df89c49
Compare
existentialism
added
PR: Bug Fix 🐛
nicolo-ribaudo
approved these changes
Apr 16, 2020
nicolo-ribaudo
changed the title
existentialism
approved these changes
Apr 20, 2020
If a nested class's `superClass` redeclares the outer class's private field and access it in a computed key, that should fail. Follow up to babel#11405.
nicolo-ribaudo
force-pushed
the
nested-private-extends
branch
from
df89c49
to
c60b24b
Compare
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a nested class's
superClassredeclares the outer class's private field and access it in a computed key, that should fail.Follow up to #11405.