Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update stage preset in babel-standalone #11395

Merged
merged 1 commit into from Apr 9, 2020
Merged

chore: update stage preset in babel-standalone #11395

merged 1 commit into from Apr 9, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Apr 9, 2020

Q                       A
Fixed Issues? Unblocks babel/website#2224
Patch: Bug Fix? I think we can ship it in patch release, if not I am okay with minor
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT
  • Removed unused syntax plugins since they have been enabled by default in babel-parser
  • Updated proposal stages
  • Added Record&Tuple syntax support

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: standalone labels Apr 9, 2020
JLHwung
JLHwung commented Apr 9, 2020
View reviewed changes
packages/babel-standalone/src/preset-stage-2.js
@@ -18,8 +18,6 @@ export default (_: any, opts: Object = {}) => {
{ legacy: decoratorsLegacy, decoratorsBeforeExport },
],
babelPlugins.proposalFunctionSent,
babelPlugins.proposalExportNamespaceFrom,
babelPlugins.proposalNumericSeparator,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are moved to stage 3.

hzoo
hzoo approved these changes Apr 9, 2020
View reviewed changes
Copy link
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we shouldn't even have the stage presets anyway 😄 so this is great (since we wanted to just have the option for the specific proposals)

@nicolo-ribaudo nicolo-ribaudo merged commit eb6d5c6 into babel:master Apr 9, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the update-babel-standalone branch April 9, 2020 18:55
@commit-lint commit-lint bot mentioned this pull request Apr 9, 2020
Merged
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 10, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@hzoo hzoo hzoo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: standalone PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JLHwung @existentialism @hzoo @nicolo-ribaudo