New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix logic to insert parens in return statements with comments #11306
Merged
nicolo-ribaudo
merged 1 commit into
babel:master
from
nicolo-ribaudo:newline-after-comment-in-return
Mar 21, 2020
Merged
Fix logic to insert parens in return statements with comments #11306
nicolo-ribaudo
merged 1 commit into
babel:master
from
nicolo-ribaudo:newline-after-comment-in-return
Mar 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: Bug Fix 🐛
A type of pull request used for our changelog categories
pkg: generator
i: regression
labels
Mar 21, 2020
1 task
1 task
existentialism
approved these changes
Mar 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow lol
JLHwung
approved these changes
Mar 21, 2020
@nicolo-ribaudo when do you think this will be published? |
As soon as #11307 is merged (I need another review). It might get delayed at most to tomorrow morning in my timezone (central europe). |
birdofpreyru
added a commit
to birdofpreyru/react-utils
that referenced
this pull request
Mar 22, 2020
The current latest `@babel/preset-react@7.9.1` contains a bug which breaks React components in obscure ways. It looks like the issue has been reported already, and the fix is ready and will be released soon. babel/babel#11305 babel/babel#11306
Closed
1 task
Seems #11307 merged. Is that possible to patch? : ) |
Published |
2 tasks
github-actions
bot
added
the
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
label
Jun 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
i: regression
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
pkg: generator
PR: Bug Fix 🐛
A type of pull request used for our changelog categories
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wow, this was super hard to debug 😬