Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add estree parsing support for export * as A #11254

Merged
merged 1 commit into from Mar 16, 2020
Merged

Add estree parsing support for export * as A #11254

merged 1 commit into from Mar 16, 2020

Conversation

existentialism
Copy link
Member

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? Y
Tests Added + Pass? Y
Documentation PR Link
Any Dependency Changes?
License MIT

Ref: estree/estree#205

@existentialism existentialism added PR: New Feature 🚀 A type of pull request used for our changelog categories area: estree labels Mar 12, 2020
nicolo-ribaudo
nicolo-ribaudo approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nicolo-ribaudo
Copy link
Member

The failing test is fixed on master

kaicataldo
kaicataldo approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@nicolo-ribaudo nicolo-ribaudo added this to the v7.9.0 milestone Mar 12, 2020
@nicolo-ribaudo nicolo-ribaudo added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Mar 12, 2020
@nicolo-ribaudo nicolo-ribaudo merged commit 20d9a10 into master Mar 16, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the estree-export-ns-from branch March 16, 2020 21:52
This was referenced Mar 22, 2020
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Mar 30, 2020
Open
Open
Open
Open
This was referenced Apr 11, 2020
Merged
Open
Open
Open
Open
Open
Open
This was referenced Apr 15, 2020
Open
Open
Open
Open
Open
Open
This was referenced Apr 22, 2020
Open
Open
Open
Open
Closed
This was referenced Apr 29, 2020
Open
Open
Merged
Open
Merged
Open
Closed
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request May 7, 2020
Open
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 16, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

Assignees
No one assigned
Labels
area: estree outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release
Projects
None yet
Milestone
v7.9.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@existentialism @nicolo-ribaudo @JLHwung @kaicataldo