Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for declare on class fields with Flow #11176

Closed
wants to merge 3 commits into from

Conversation

nicolo-ribaudo
Copy link
Member

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? Yes
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Flow has recently landed support for declare fields, similar to TypeScript. (facebook/flow@11b7adb)

This PR implements parser support, and adds an allowDeclareFields option to the transform plugin to mirror the one of @babel/plugin-transform-typescript. In Babel 8 it will be enabled by default.

Even if it's not released yet in Flow, I'm adding this to the v7.9.0 milestone since Flow is released about once a week.

cc @mroch

@nicolo-ribaudo nicolo-ribaudo added PR: New Feature 🚀 A type of pull request used for our changelog categories area: flow pkg: parser labels Feb 27, 2020
@nicolo-ribaudo nicolo-ribaudo added this to the v7.9.0 milestone Feb 27, 2020
@nicolo-ribaudo
Copy link
Member Author

I closed this PR because new commits didn't appear, and...

Schermata da 2020-02-27 15-33-49

Reponed at #11178

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 29, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: flow outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant