Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable the BABEL_TYPES_8_BREAKING flag in @babel/types #11172

Merged
merged 1 commit into from Jun 25, 2020
Merged

Enable the BABEL_TYPES_8_BREAKING flag in @babel/types #11172

merged 1 commit into from Jun 25, 2020

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Feb 26, 2020 •
edited by gitpod-io bot

Q                       A
Patch: Bug Fix?
Major: Breaking Change? Y
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Follow up to #10917 (which was a cleanup of #5971)

@nicolo-ribaudo nicolo-ribaudo added PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release pkg: types labels Feb 26, 2020
@nicolo-ribaudo nicolo-ribaudo added this to the Babel 8.x milestone Feb 26, 2020
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Feb 26, 2020
Closed
1 task
@nicolo-ribaudo
Copy link
Member Author

CI failure is unrelated

JLHwung
JLHwung approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolo-ribaudo Can you rebase?

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/24637/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c9c8cb2:

Sandbox Source
mutable-pine-eblnp Configuration
aged-dawn-sq9vt Configuration

@nicolo-ribaudo nicolo-ribaudo changed the title Enable the BABEL_TYPES_8_BREAKING flag in @babel/types Enable the BABEL_TYPES_8_BREAKING flag in @babel/types Jun 25, 2020
@nicolo-ribaudo nicolo-ribaudo merged commit b0abc2d into babel:next-8-dev Jun 25, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the types-breaking branch June 25, 2020 21:56
nicolo-ribaudo added a commit that referenced this pull request Jun 25, 2020
@nicolo-ribaudo
Enable the BABEL_TYPES_8_BREAKING flag in @babel/types (#11172)
8b8c32d
nicolo-ribaudo added a commit that referenced this pull request Jul 5, 2020
@nicolo-ribaudo
Enable the BABEL_TYPES_8_BREAKING flag in @babel/types (#11172)
e26d360
nicolo-ribaudo added a commit that referenced this pull request Aug 28, 2020
@nicolo-ribaudo
Enable the BABEL_TYPES_8_BREAKING flag in @babel/types (#11172)
3d8aa02
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Sep 25, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2020
@JLHwung JLHwung removed this from the v8.0.0 milestone Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@JLHwung JLHwung JLHwung approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: types PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nicolo-ribaudo @babel-bot @existentialism @JLHwung @kaicataldo