Use rollup-plugin-node-polyfills instead of node-globals+node-builtins #11098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
the
PR: Internal 🏠
JLHwung
reviewed
Feb 6, 2020
yarn.lock
Outdated
| magic-string@^0.25.2: | ||
| version "0.25.4" | ||
| resolved "https://registry.yarnpkg.com/magic-string/-/magic-string-0.25.4.tgz#325b8a0a79fc423db109b77fd5a19183b7ba5143" | ||
| integrity sha512-oycWO9nEVAP2RVPbIoDoA4Y7LFIJ3xRYov93gAyJhZkET1tNuB0u7uWkZS2LpBWTJUWnmau/To8ECWRC+jKNfw== | ||
| dependencies: | ||
| sourcemap-codec "^1.4.4" | ||
|
|
||
| magic-string@^0.25.3: |
There was a problem hiding this comment.
nit: Can you run yarn-deduplicate?
JLHwung
approved these changes
Feb 6, 2020
|
I'll merge this not to |
nicolo-ribaudo
force-pushed
the
rollup-inject-polyfills
branch
from
e5b7ae0
to
ed6aaf5
Compare
|
I have cherry-picked this PR to #10747, since they depend on each other to pass CI. |
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10747 is currently blocked by calvinmetcalf/rollup-plugin-node-globals#34, which is using an old acorn version which doesn't support Node 10 features.
There are three different PRs to update acorn in that package:
However, the last release was in Sept 2018.
In this PR, I am replacing it with
rollup-plugin-node-polyfills: it's a fork ofrollup-plugin-node-builtins(used for built-in modules) which also polyfills global Node variables, maintained by the author of the second PR I linked.It seems that the readme is still a copy of
rollup-plugin-node-builtins, but looking at the source code and at rollup/rollup#2881 it seems to be exactly what we want.PS. @manucorporat Are there any plans to move the plugin to https://github.com/rollup/plugins? Your plugin seems to be a fundamental piece of the ecosystem, and it would make sense to move it to the rollup org.