Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make isReferenced return false for method parameter name #11089

Merged
merged 5 commits into from Feb 5, 2020
Merged

Make isReferenced return false for method parameter name #11089

merged 5 commits into from Feb 5, 2020

Commits on Feb 3, 2020

  1. Change isReferenced to return false for object/class method parameter… 

    … names.
    @brokensandals
    brokensandals committed Feb 3, 2020
    Copy the full SHA
    f4f53c5 View commit details
    Browse the repository at this point in the history

  2. use indexOf instead of for-of loop

    @brokensandals
    brokensandals committed Feb 3, 2020
    Copy the full SHA
    9776597 View commit details
    Browse the repository at this point in the history

  3. replace .indexOf check with .includes and assume parent.params … 

    …exists

Co-Authored-By: Justin Ridgewell <justin@ridgewell.name>
    @brokensandals @jridgewell
    brokensandals and jridgewell committed Feb 3, 2020
    Copy the full SHA
    f81b3cb View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2020

  1. check .params within case block for ClassMethod/ClassPrivateMethod/Ob… 

    …jectMethod only
    @brokensandals
    brokensandals committed Feb 4, 2020
    Copy the full SHA
    94addd0 View commit details
    Browse the repository at this point in the history

  2. add comment clarifying that case clause fall-through is intentional

    @brokensandals
    brokensandals committed Feb 4, 2020
    Copy the full SHA
    ef3c0e5 View commit details
    Browse the repository at this point in the history