Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added jsescOptions to Numeric Literals #11028

Merged
merged 9 commits into from
Mar 16, 2020
Merged

Added jsescOptions to Numeric Literals #11028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c655e7d
Added jsescOptions to Numeric Literals
sidntrivedi012 Jan 17, 2020
9649bed
Added tests and hexadecimal opts to NumericLiterals
sidntrivedi012 Jan 18, 2020
8a47737
Fixed the bug of every numeric literal being coverted to hex
sidntrivedi012 Jan 19, 2020
f87501e
Added conditions when jsesc should be applied
sidntrivedi012 Jan 20, 2020
dc87816
Removed numbers and lowercaseHex from format object
sidntrivedi012 Jan 20, 2020
bdf978f
Added newline to test of jsonEscape (to exclude the change)
sidntrivedi012 Jan 20, 2020
e89ac38
Modified conditions to apply jsesc
sidntrivedi012 Jan 21, 2020
7b3eea7
Made the required changes.
sidntrivedi012 Jan 21, 2020
7533933
Using node.value instead of value
sidntrivedi012 Jan 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/babel-generator/src/generators/types.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,11 @@ export function NullLiteral() {

export function NumericLiteral(node: Object) {
const raw = this.getPossibleRaw(node);
const opts = this.format.jsescOption;
const value = node.value + "";
if (raw == null) {
if (opts.numbers) {
this.number(jsesc(node.value, opts));
} else if (raw == null) {
this.number(value); // normalize
} else if (this.format.minified) {
this.number(raw.length < value.length ? raw : value);
Expand Down
0 ...erator/test/fixtures/escapes/options.json → .../fixtures/escapes/jsonEscape/options.json
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions packages/babel-generator/test/fixtures/escapes/numeric-literals/input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
let x = 42
6 changes: 6 additions & 0 deletions packages/babel-generator/test/fixtures/escapes/numeric-literals/options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"jsescOption": {
"numbers": "hexadecimal",
"lowercaseHex": true
}
}
1 change: 1 addition & 0 deletions packages/babel-generator/test/fixtures/escapes/numeric-literals/output.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
let x = 0x2a;