fix: isPluginRequired returns the opposite result in v7.8.0

[sodatea]

Q	A
Fixed Issues?
Patch: Bug Fix?	👍
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?
Documentation PR Link
Any Dependency Changes?
License	MIT

As far as I can tell, the new isRequired function in this PR https://github.com/babel/babel/pull/10899/files does the same job as the legacy isPluginRequired, so the ! here seems incorrect.

It breaks Vue CLI's tests at the moment (though it seems few people have noticed).

[JLHwung]

LGTM. Likely a glitch when refactoring targetsSupported into isRequired.

It breaks Vue CLI's tests at the moment

We do have vue-cli e2e tests:

babel/scripts/integration-tests/e2e-vue-cli.sh

Line 33 in 2ccc451

CI=true yarn test -p babel

Could you post the broken CI link? It should have been captured by the e2e tests.

[sodatea]

https://circleci.com/gh/sodatea/vue-cli/2224?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
I updated the lockfile in an unrelated PR and encountered this issue.

The e2e test script didn't include the preset package. Should be yarn test -p babel,babel-preset-app

[JLHwung]

@sodatea Thanks! Can you also update the babel/scripts/integration-tests/e2e-vue-cli.sh? So it can be captured in e2e tests.

[nicolo-ribaudo]

Will release in a few hours 👍

[nicolo-ribaudo]

Published as 7.8.2!

[sodatea]

I went to sleep after the last reply 😅
Thanks for the quick action!