When reading a new string, U+2028/2029 should correctly set the new column #10944
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| (`before after`); | ||
| // ^ That's a U+2028 LINE SEPARATOR UTF-16 char (between 'before' and 'after') | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| { | ||
| "type": "File", | ||
| "start": 0, | ||
| "end": 101, | ||
| "loc": { | ||
| "start": { | ||
| "line": 1, | ||
| "column": 0 | ||
| }, | ||
| "end": { | ||
| "line": 3, | ||
| "column": 83 | ||
| } | ||
| }, | ||
| "program": { | ||
| "type": "Program", | ||
| "start": 0, | ||
| "end": 101, | ||
| "loc": { | ||
| "start": { | ||
| "line": 1, | ||
| "column": 0 | ||
| }, | ||
| "end": { | ||
| "line": 3, | ||
| "column": 83 | ||
| } | ||
| }, | ||
| "sourceType": "script", | ||
| "interpreter": null, | ||
| "body": [ | ||
| { | ||
| "type": "ExpressionStatement", | ||
| "start": 0, | ||
| "end": 17, | ||
| "loc": { | ||
| "start": { | ||
| "line": 1, | ||
| "column": 0 | ||
| }, | ||
| "end": { | ||
| "line": 2, | ||
| "column": 8 | ||
|
There was a problem hiding this comment. Keep in mind that the |
||
| } | ||
| }, | ||
| "expression": { | ||
| "type": "TemplateLiteral", | ||
| "start": 1, | ||
| "end": 15, | ||
| "loc": { | ||
| "start": { | ||
| "line": 1, | ||
| "column": 1 | ||
| }, | ||
| "end": { | ||
| "line": 2, | ||
| "column": 6 | ||
| } | ||
| }, | ||
| "expressions": [], | ||
| "quasis": [ | ||
| { | ||
| "type": "TemplateElement", | ||
| "start": 2, | ||
| "end": 14, | ||
| "loc": { | ||
| "start": { | ||
| "line": 1, | ||
| "column": 2 | ||
| }, | ||
| "end": { | ||
| "line": 2, | ||
| "column": 5 | ||
| } | ||
| }, | ||
| "value": { | ||
| "raw": "before after", | ||
| "cooked": "before after" | ||
| }, | ||
| "tail": true | ||
| } | ||
| ], | ||
| "extra": { | ||
| "parenthesized": true, | ||
| "parenStart": 0 | ||
| } | ||
| }, | ||
| "trailingComments": [ | ||
| { | ||
| "type": "CommentLine", | ||
| "value": " ^ That's a U+2028 LINE SEPARATOR UTF-16 char (between 'before' and 'after')", | ||
| "start": 18, | ||
| "end": 101, | ||
| "loc": { | ||
| "start": { | ||
| "line": 3, | ||
| "column": 0 | ||
| }, | ||
| "end": { | ||
| "line": 3, | ||
| "column": 83 | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "directives": [] | ||
| }, | ||
| "comments": [ | ||
| { | ||
| "type": "CommentLine", | ||
| "value": " ^ That's a U+2028 LINE SEPARATOR UTF-16 char (between 'before' and 'after')", | ||
| "start": 18, | ||
| "end": 101, | ||
| "loc": { | ||
| "start": { | ||
| "line": 3, | ||
| "column": 0 | ||
| }, | ||
| "end": { | ||
| "line": 3, | ||
| "column": 83 | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| (`before after`); | ||
| // ^ That's a U+2029 PARAGRAPH SEPARATOR UTF-16 char (between 'before' and 'after') |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| { | ||
| "type": "File", | ||
| "start": 0, | ||
| "end": 106, | ||
| "loc": { | ||
| "start": { | ||
| "line": 1, | ||
| "column": 0 | ||
| }, | ||
| "end": { | ||
| "line": 3, | ||
| "column": 88 | ||
| } | ||
| }, | ||
| "program": { | ||
| "type": "Program", | ||
| "start": 0, | ||
| "end": 106, | ||
| "loc": { | ||
| "start": { | ||
| "line": 1, | ||
| "column": 0 | ||
| }, | ||
| "end": { | ||
| "line": 3, | ||
| "column": 88 | ||
| } | ||
| }, | ||
| "sourceType": "script", | ||
| "interpreter": null, | ||
| "body": [ | ||
| { | ||
| "type": "ExpressionStatement", | ||
| "start": 0, | ||
| "end": 17, | ||
| "loc": { | ||
| "start": { | ||
| "line": 1, | ||
| "column": 0 | ||
| }, | ||
| "end": { | ||
| "line": 2, | ||
| "column": 8 | ||
| } | ||
| }, | ||
| "expression": { | ||
| "type": "TemplateLiteral", | ||
| "start": 1, | ||
| "end": 15, | ||
| "loc": { | ||
| "start": { | ||
| "line": 1, | ||
| "column": 1 | ||
| }, | ||
| "end": { | ||
| "line": 2, | ||
| "column": 6 | ||
| } | ||
| }, | ||
| "expressions": [], | ||
| "quasis": [ | ||
| { | ||
| "type": "TemplateElement", | ||
| "start": 2, | ||
| "end": 14, | ||
| "loc": { | ||
| "start": { | ||
| "line": 1, | ||
| "column": 2 | ||
| }, | ||
| "end": { | ||
| "line": 2, | ||
| "column": 5 | ||
| } | ||
| }, | ||
| "value": { | ||
| "raw": "before after", | ||
| "cooked": "before after" | ||
| }, | ||
| "tail": true | ||
| } | ||
| ], | ||
| "extra": { | ||
| "parenthesized": true, | ||
| "parenStart": 0 | ||
| } | ||
| }, | ||
| "trailingComments": [ | ||
| { | ||
| "type": "CommentLine", | ||
| "value": " ^ That's a U+2029 PARAGRAPH SEPARATOR UTF-16 char (between 'before' and 'after')", | ||
| "start": 18, | ||
| "end": 106, | ||
| "loc": { | ||
| "start": { | ||
| "line": 3, | ||
| "column": 0 | ||
| }, | ||
| "end": { | ||
| "line": 3, | ||
| "column": 88 | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "directives": [] | ||
| }, | ||
| "comments": [ | ||
| { | ||
| "type": "CommentLine", | ||
| "value": " ^ That's a U+2029 PARAGRAPH SEPARATOR UTF-16 char (between 'before' and 'after')", | ||
| "start": 18, | ||
| "end": 106, | ||
| "loc": { | ||
| "start": { | ||
| "line": 3, | ||
| "column": 0 | ||
| }, | ||
| "end": { | ||
| "line": 3, | ||
| "column": 88 | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The behaviour of U+2028 in string template is not changed. Adding test here for coverage.