Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StringNumericLiteral does not include NumericLiteralSeparator #10938

Merged
merged 1 commit into from Jan 10, 2020
Merged

StringNumericLiteral does not include NumericLiteralSeparator #10938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 0 additions & 16 deletions packages/babel-plugin-proposal-numeric-separator/src/index.js
View file
Open in desktop
@@ -1,30 +1,14 @@
import { declare } from "@babel/helper-plugin-utils";
import syntaxNumericSeparator from "@babel/plugin-syntax-numeric-separator";
import { types as t } from "@babel/core";

export default declare(api => {
api.assertVersion(7);

function replaceNumberArg({ node }) {
if (node.callee.name !== "Number") {
return;
}

const arg = node.arguments[0];
if (!t.isStringLiteral(arg)) {
return;
}

arg.value = arg.value.replace(/_/g, "");
}

return {
name: "proposal-numeric-separator",
inherits: syntaxNumericSeparator,

visitor: {
CallExpression: replaceNumberArg,
NewExpression: replaceNumberArg,
NumericLiteral({ node }) {
const { extra } = node;
if (extra && /_/.test(extra.raw)) {
Expand Down
19 changes: 0 additions & 19 deletions packages/babel-plugin-proposal-numeric-separator/test/fixtures/number/exec.js
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions packages/babel-plugin-proposal-numeric-separator/test/fixtures/number/options.json
View file
Open in desktop

This file was deleted.