Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Object.getOwnPropertySymbols called on non-object #10902

Merged
merged 2 commits into from Dec 21, 2019
Merged

fix: Object.getOwnPropertySymbols called on non-object #10902

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1d0483
fix: Object.getOwnPropertySymbols called on non-object
bassaer Dec 20, 2019
1366ed3
convert Object
bassaer Dec 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/babel-helpers/src/helpers.js
View file
Open in desktop
Expand Up @@ -399,7 +399,7 @@ helpers.objectSpread = helper("7.0.0-beta.0")`
var source = (arguments[i] != null) ? arguments[i] : {};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we can add Object to arguments[i] and forget about Object(source) later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean like this?

var source = (arguments[i] != null) ?  Object(arguments[i]) : {};

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed 1366ed3

var ownKeys = Object.keys(Object(source));
if (typeof Object.getOwnPropertySymbols === 'function') {
ownKeys = ownKeys.concat(Object.getOwnPropertySymbols(source).filter(function(sym) {
ownKeys = ownKeys.concat(Object.getOwnPropertySymbols(Object(source)).filter(function(sym) {
return Object.getOwnPropertyDescriptor(source, sym).enumerable;
}));
}
Expand Down