New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: lost leading comment after named import #10901
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
elevatebart
commented
Dec 20, 2019
Q | A |
---|---|
Fixed Issues? | Fixes #10892 |
Patch: Bug Fix? | Yes |
Major: Breaking Change? | No |
Minor: New Feature? | No |
Tests Added + Pass? | Yes |
Documentation PR Link | |
Any Dependency Changes? | No |
License | MIT |
existentialism
added
area: comments
PR: Bug Fix 🐛
A type of pull request used for our changelog categories
labels
Dec 20, 2019
@elevatebart If needed, you can ping us to restart the build 😉 |
nicolo-ribaudo
approved these changes
Dec 21, 2019
Ping @JLHwung, when you have min, would you tell me what you think? Thank you again |
@elevatebart Looks good to me, thanks! |
JLHwung
approved these changes
Dec 22, 2019
This was referenced Feb 22, 2020
This was referenced Mar 7, 2020
This was referenced Mar 14, 2020
This was referenced Mar 22, 2020
github-actions
bot
added
the
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
label
Mar 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area: comments
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
PR: Bug Fix 🐛
A type of pull request used for our changelog categories
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.