Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lost leading comment after named import #10901

Merged
merged 5 commits into from Dec 22, 2019

Conversation

elevatebart
Copy link
Contributor

Q                       A
Fixed Issues? Fixes #10892
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? No
License MIT

@existentialism existentialism added area: comments PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Dec 20, 2019
@nicolo-ribaudo
Copy link
Member

@elevatebart If needed, you can ping us to restart the build 😉

@elevatebart
Copy link
Contributor Author

Ping @JLHwung, when you have min, would you tell me what you think?

Thank you again

@JLHwung
Copy link
Contributor

JLHwung commented Dec 22, 2019

@elevatebart Looks good to me, thanks!

@nicolo-ribaudo nicolo-ribaudo merged commit f651f22 into babel:master Dec 22, 2019
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Mar 23, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: comments outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leading comment is lost when using named import just before
4 participants