Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "throw a TypeError if identifier validation fails (#10621)" #10650

Merged
merged 1 commit into from Nov 5, 2019
Merged

Revert "throw a TypeError if identifier validation fails (#10621)" #10650

merged 1 commit into from Nov 5, 2019

Conversation

nicolo-ribaudo
Copy link
Member

This reverts commit c7d8b8a.

Q                       A
Fixed Issues? Fixes #10645
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@nicolo-ribaudo nicolo-ribaudo added i: regression PR: Bug Fix 🐛 A type of pull request used for our changelog categories Priority: High labels Nov 5, 2019
@nicolo-ribaudo nicolo-ribaudo merged commit bf48fca into babel:master Nov 5, 2019
@nicolo-ribaudo nicolo-ribaudo deleted the hotfix branch November 5, 2019 13:43
@AdeilsonSuperlogica AdeilsonSuperlogica mentioned this pull request Nov 5, 2019
Closed
JLHwung
JLHwung reviewed Nov 5, 2019
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make it a warning afterwards and defer to 8.x.

This was referenced Nov 14, 2019
Merged
Merged
This was referenced Nov 28, 2019
Open
Open
This was referenced Dec 5, 2019
Open
Merged
@snyk-bot snyk-bot mentioned this pull request Jan 12, 2020
Open
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 4, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung left review comments

Assignees
No one assigned
Labels
i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories Priority: High
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error index.js: "" is not a valid identifer name error with 7.7.0
2 participants
@nicolo-ribaudo @JLHwung