Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[parser] Parse only modifiers of actual methods #10594

Merged
merged 2 commits into from Oct 29, 2019
Merged

[parser] Parse only modifiers of actual methods #10594

merged 2 commits into from Oct 29, 2019

Conversation

zant
Copy link
Contributor

@zant zant commented Oct 23, 2019 •
edited

Q                       A
Fixed Issues? Follow-up from #10582 comment
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Any Dependency Changes? No
License MIT

i've did what in my opinion was the most trivial solution and added a test as an start point, reviews are highly appreciated

@nicolo-ribaudo nicolo-ribaudo added area: typescript PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Oct 25, 2019
JLHwung
JLHwung approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
The CI error is unrelated.

@JLHwung
Copy link
Contributor

JLHwung commented Oct 29, 2019

@gonzarodriguezt Could you rebase on master?

nicolo-ribaudo
nicolo-ribaudo approved these changes Oct 29, 2019
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicolo-ribaudo nicolo-ribaudo merged commit b6ef968 into babel:master Oct 29, 2019
@zant
Copy link
Contributor Author

zant commented Oct 29, 2019

@JLHwung Sorry i was afk!

It's a pleasure @nicolo-ribaudo 🙂

@snyk-bot snyk-bot mentioned this pull request Nov 14, 2019
Merged
This was referenced Nov 28, 2019
Open
Open
This was referenced Dec 5, 2019
Open
Merged
@snyk-bot snyk-bot mentioned this pull request Jan 12, 2020
Open
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 28, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zant @JLHwung @nicolo-ribaudo