Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow TypeScript type assertions in array destructuring #10592

Merged
merged 5 commits into from Nov 11, 2019
Merged

Allow TypeScript type assertions in array destructuring #10592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1090466
Add test
SakibulMowla Oct 20, 2019
302deb6
Add fix
SakibulMowla Oct 20, 2019
d05c545
Fix test, destructure with as assertion
SakibulMowla Oct 26, 2019
a48a37a
Add angle-bracket assertion case
SakibulMowla Oct 26, 2019
35786c7
Use isBinding to make typeCastToParameter decision
SakibulMowla Oct 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 12 additions & 5 deletions packages/babel-parser/src/plugins/typescript/index.js
View file
Open in desktop
Expand Up @@ -2424,7 +2424,10 @@ export default (superClass: Class<Parser>): Class<Parser> =>
}
}

toAssignableList(exprList: N.Expression[]): $ReadOnlyArray<N.Pattern> {
toAssignableList(
exprList: N.Expression[],
isBinding: ?boolean,
): $ReadOnlyArray<N.Pattern> {
for (let i = 0; i < exprList.length; i++) {
const expr = exprList[i];
if (!expr) continue;
Expand All @@ -2434,10 +2437,14 @@ export default (superClass: Class<Parser>): Class<Parser> =>
break;
case "TSAsExpression":
case "TSTypeAssertion":
this.raise(
expr.start,
"Unexpected type cast in parameter position.",
);
if (!isBinding) {
exprList[i] = this.typeCastToParameter(expr);
} else {
this.raise(
expr.start,
"Unexpected type cast in parameter position.",
);
}
break;
}
}
Expand Down
2 changes: 2 additions & 0 deletions packages/babel-parser/test/fixtures/typescript/cast/destructure-and-assign/input.ts
View file
Open in desktop
@@ -0,0 +1,2 @@
[a as number] = [42];
[<number>a] = [42];
269 changes: 269 additions & 0 deletions packages/babel-parser/test/fixtures/typescript/cast/destructure-and-assign/output.json
View file
Open in desktop
@@ -0,0 +1,269 @@
{
"type": "File",
"start": 0,
"end": 41,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 2,
"column": 19
}
},
"program": {
"type": "Program",
"start": 0,
"end": 41,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 2,
"column": 19
}
},
"sourceType": "module",
"interpreter": null,
"body": [
{
"type": "ExpressionStatement",
"start": 0,
"end": 21,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 1,
"column": 21
}
},
"expression": {
"type": "AssignmentExpression",
"start": 0,
"end": 20,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 1,
"column": 20
}
},
"operator": "=",
"left": {
"type": "ArrayPattern",
"start": 0,
"end": 13,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 1,
"column": 13
}
},
"elements": [
{
"type": "Identifier",
"start": 1,
"end": 12,
"loc": {
"start": {
"line": 1,
"column": 1
},
"end": {
"line": 1,
"column": 12
},
"identifierName": "a"
},
"name": "a",
"typeAnnotation": {
"type": "TSNumberKeyword",
"start": 6,
"end": 12,
"loc": {
"start": {
"line": 1,
"column": 6
},
"end": {
"line": 1,
"column": 12
}
}
}
}
]
},
"right": {
"type": "ArrayExpression",
"start": 16,
"end": 20,
"loc": {
"start": {
"line": 1,
"column": 16
},
"end": {
"line": 1,
"column": 20
}
},
"elements": [
{
"type": "NumericLiteral",
"start": 17,
"end": 19,
"loc": {
"start": {
"line": 1,
"column": 17
},
"end": {
"line": 1,
"column": 19
}
},
"extra": {
"rawValue": 42,
"raw": "42"
},
"value": 42
}
]
}
}
},
{
"type": "ExpressionStatement",
"start": 22,
"end": 41,
"loc": {
"start": {
"line": 2,
"column": 0
},
"end": {
"line": 2,
"column": 19
}
},
"expression": {
"type": "AssignmentExpression",
"start": 22,
"end": 40,
"loc": {
"start": {
"line": 2,
"column": 0
},
"end": {
"line": 2,
"column": 18
}
},
"operator": "=",
"left": {
"type": "ArrayPattern",
"start": 22,
"end": 33,
"loc": {
"start": {
"line": 2,
"column": 0
},
"end": {
"line": 2,
"column": 11
}
},
"elements": [
{
"type": "Identifier",
"start": 31,
"end": 30,
"loc": {
"start": {
"line": 2,
"column": 9
},
"end": {
"line": 2,
"column": 8
},
"identifierName": "a"
},
"name": "a",
"typeAnnotation": {
"type": "TSNumberKeyword",
"start": 24,
"end": 30,
"loc": {
"start": {
"line": 2,
"column": 2
},
"end": {
"line": 2,
"column": 8
}
}
}
}
]
},
"right": {
"type": "ArrayExpression",
"start": 36,
"end": 40,
"loc": {
"start": {
"line": 2,
"column": 14
},
"end": {
"line": 2,
"column": 18
}
},
"elements": [
{
"type": "NumericLiteral",
"start": 37,
"end": 39,
"loc": {
"start": {
"line": 2,
"column": 15
},
"end": {
"line": 2,
"column": 17
}
},
"extra": {
"rawValue": 42,
"raw": "42"
},
"value": 42
}
]
}
}
}
],
"directives": []
}
}