New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump babel-types to ^7.6.3 #10568
Bump babel-types to ^7.6.3 #10568
Conversation
@@ -213,7 +213,7 @@ yarn-install: clean-all | |||
yarn --ignore-engines | |||
|
|||
lerna-bootstrap: yarn-install | |||
yarn lerna bootstrap -- --ignore-engines |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR, but we should try to remove --ignore-engines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we should give it a try after we drop node 8 support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we rely on a dependency which doesn't work with node 6?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see. We have proved it on #10249.
Bumped
@babel/types
dependencies to^7.6.3
which depends on secure lodash versions. This PR also fixes incorrect lerna bootstrap options introduced at #10249.