Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[parser] Exception to 8 and 9 in tagged template #10567

Merged
merged 1 commit into from Oct 16, 2019

Conversation

pnowak
Copy link
Contributor

@pnowak pnowak commented Oct 16, 2019

Q                       A
Fixed Issues? Fixes #10437
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@nicolo-ribaudo nicolo-ribaudo added pkg: parser PR: Spec Compliance 👓 A type of pull request used for our changelog categories labels Oct 16, 2019
@nicolo-ribaudo
Copy link
Member

Thanks!

@nicolo-ribaudo nicolo-ribaudo merged commit 5800fc9 into babel:master Oct 16, 2019
@pvdz
Copy link

pvdz commented Oct 21, 2019

Thanks! :)
(Could have used a tagged template test case, since tagged templates have a special case for illegal escapes)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Spec Compliance 👓 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[parser] Tagged template with \8 should set value to null
5 participants