Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix prepublish-build #10530

Merged
merged 1 commit into from Oct 9, 2019
Merged

fix prepublish-build #10530

merged 1 commit into from Oct 9, 2019

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Oct 8, 2019

Q                       A
Fixed Issues? make prepublish throws error
Patch: Bug Fix? yes
License MIT

This PR fixes a regression introduced at #10506. Before that build-dist depended on build, but in #10506, build is revised to include build-dist as the last step, therefore prepublish-build should
call build instead of build-dist.

hzoo
hzoo approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@hzoo hzoo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh no unit tests for publish other than doing it 😂

@nicolo-ribaudo nicolo-ribaudo merged commit 3ad4c70 into babel:master Oct 9, 2019
@JLHwung JLHwung deleted the fix-make-prepublish branch October 22, 2019 18:57
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 24, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hzoo hzoo hzoo approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
area: publishing process outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JLHwung @hzoo @nicolo-ribaudo