Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes UMD callsite to be more likely to pass in the intended object. #10477

Merged
merged 2 commits into from Oct 29, 2019
Merged

Changes UMD callsite to be more likely to pass in the intended object. #10477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e22259
Changes UMD callsite to be more likely to pass in the intended object.
MicahZoltu Sep 21, 2019
20b4f43
Update tests
jridgewell Sep 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ction-name/test/fixtures/function-name/export-default-arrow-renaming-module-umd/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(mod.exports);
global.input = mod.exports;
}
})(this, function (_exports) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_exports) {
"use strict";

Object.defineProperty(_exports, "__esModule", {
Expand Down
6 changes: 5 additions & 1 deletion packages/babel-plugin-transform-modules-umd/src/index.js
View file
Open in desktop
Expand Up @@ -27,7 +27,11 @@ const buildWrapper = template(`

GLOBAL_TO_ASSIGN;
}
})(this, function(IMPORT_NAMES) {
})(
typeof globalThis === "object" ? globalThis
: typeof self === "object" ? self
: this,
function(IMPORT_NAMES) {
})
`);

Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-transform-modules-umd/test/fixtures/loose/export-default-10/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(mod.exports);
global.input = mod.exports;
}
})(this, function (_exports) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_exports) {
"use strict";

_exports.__esModule = true;
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-transform-modules-umd/test/fixtures/loose/export-default-11/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(mod.exports);
global.input = mod.exports;
}
})(this, function (_exports) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_exports) {
"use strict";

_exports.__esModule = true;
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-transform-modules-umd/test/fixtures/loose/export-default-2/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(mod.exports);
global.input = mod.exports;
}
})(this, function (_exports) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_exports) {
"use strict";

_exports.__esModule = true;
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-transform-modules-umd/test/fixtures/loose/export-default-3/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(mod.exports);
global.input = mod.exports;
}
})(this, function (_exports) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_exports) {
"use strict";

_exports.__esModule = true;
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-transform-modules-umd/test/fixtures/loose/export-default-4/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(mod.exports);
global.input = mod.exports;
}
})(this, function (_exports) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_exports) {
"use strict";

_exports.__esModule = true;
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-transform-modules-umd/test/fixtures/loose/export-default-5/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(mod.exports);
global.input = mod.exports;
}
})(this, function (_exports) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_exports) {
"use strict";

_exports.__esModule = true;
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-transform-modules-umd/test/fixtures/loose/export-default-6/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(mod.exports);
global.input = mod.exports;
}
})(this, function (_exports) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_exports) {
"use strict";

_exports.__esModule = true;
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-transform-modules-umd/test/fixtures/loose/export-default-7/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(mod.exports);
global.input = mod.exports;
}
})(this, function (_exports) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_exports) {
"use strict";

_exports.__esModule = true;
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-transform-modules-umd/test/fixtures/loose/export-default-8/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(mod.exports);
global.input = mod.exports;
}
})(this, function (_exports) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_exports) {
"use strict";

_exports.__esModule = true;
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-transform-modules-umd/test/fixtures/loose/export-default-9/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(mod.exports);
global.input = mod.exports;
}
})(this, function (_exports) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_exports) {
"use strict";

_exports.__esModule = true;
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-transform-modules-umd/test/fixtures/loose/export-default/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(mod.exports);
global.input = mod.exports;
}
})(this, function (_exports) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_exports) {
"use strict";

_exports.__esModule = true;
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-transform-modules-umd/test/fixtures/loose/export-from-2/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(mod.exports, global.foo);
global.input = mod.exports;
}
})(this, function (_exports, _foo) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_exports, _foo) {
"use strict";

_exports.__esModule = true;
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-transform-modules-umd/test/fixtures/loose/export-from-3/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(mod.exports, global.foo);
global.input = mod.exports;
}
})(this, function (_exports, _foo) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_exports, _foo) {
"use strict";

_exports.__esModule = true;
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-transform-modules-umd/test/fixtures/loose/export-from-4/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(mod.exports, global.foo);
global.input = mod.exports;
}
})(this, function (_exports, _foo) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_exports, _foo) {
"use strict";

_exports.__esModule = true;
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-transform-modules-umd/test/fixtures/loose/export-from-5/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(mod.exports, global.foo);
global.input = mod.exports;
}
})(this, function (_exports, _foo) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_exports, _foo) {
"use strict";

_exports.__esModule = true;
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-transform-modules-umd/test/fixtures/loose/export-from-6/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(mod.exports, global.foo);
global.input = mod.exports;
}
})(this, function (_exports, _foo) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_exports, _foo) {
"use strict";

_exports.__esModule = true;
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-transform-modules-umd/test/fixtures/loose/export-from/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(mod.exports, global.foo);
global.input = mod.exports;
}
})(this, function (_exports, _foo) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_exports, _foo) {
"use strict";

_exports.__esModule = true;
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-transform-modules-umd/test/fixtures/loose/export-named-2/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(mod.exports);
global.input = mod.exports;
}
})(this, function (_exports) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_exports) {
"use strict";

_exports.__esModule = true;
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-transform-modules-umd/test/fixtures/loose/export-named-3/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(mod.exports);
global.input = mod.exports;
}
})(this, function (_exports) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_exports) {
"use strict";

_exports.__esModule = true;
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-transform-modules-umd/test/fixtures/loose/export-named-4/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(mod.exports);
global.input = mod.exports;
}
})(this, function (_exports) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_exports) {
"use strict";

_exports.__esModule = true;
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-transform-modules-umd/test/fixtures/loose/export-named-5/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(mod.exports);
global.input = mod.exports;
}
})(this, function (_exports) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_exports) {
"use strict";

_exports.__esModule = true;
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-transform-modules-umd/test/fixtures/loose/export-named/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(mod.exports);
global.input = mod.exports;
}
})(this, function (_exports) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_exports) {
"use strict";

_exports.__esModule = true;
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-transform-modules-umd/test/fixtures/loose/exports-variable/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(mod.exports);
global.input = mod.exports;
}
})(this, function (_exports) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_exports) {
"use strict";

_exports.__esModule = true;
Expand Down
2 changes: 1 addition & 1 deletion ...s/babel-plugin-transform-modules-umd/test/fixtures/loose/get-module-name-option/output.js
View file
Open in desktop
Expand Up @@ -10,6 +10,6 @@
factory();
global.myCustomModuleName = mod.exports;
}
})(this, function () {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function () {
"use strict";
});
2 changes: 1 addition & 1 deletion ...s/babel-plugin-transform-modules-umd/test/fixtures/loose/hoist-function-exports/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(mod.exports, global.evens);
global.input = mod.exports;
}
})(this, function (_exports, _evens) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_exports, _evens) {
"use strict";

_exports.__esModule = true;
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-transform-modules-umd/test/fixtures/loose/imports-default/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(global.foo);
global.input = mod.exports;
}
})(this, function (_foo) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_foo) {
"use strict";

_foo = babelHelpers.interopRequireDefault(_foo);
Expand Down
2 changes: 1 addition & 1 deletion ...form-modules-umd/test/fixtures/loose/imports-exact-globals-false-with-overrides/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(global.fooBAR, global.fooBAR, global.fizzBuzz);
global.input = mod.exports;
}
})(this, function (_fooBar, _fooBar2, _fizzbuzz) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_fooBar, _fooBar2, _fizzbuzz) {
"use strict";

_fooBar = babelHelpers.interopRequireDefault(_fooBar);
Expand Down
2 changes: 1 addition & 1 deletion ...el-plugin-transform-modules-umd/test/fixtures/loose/imports-exact-globals-false/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(global.fooBar, global.fooBar, global.fizzbuzz);
global.input = mod.exports;
}
})(this, function (_fooBar, _fooBar2, _fizzbuzz) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_fooBar, _fooBar2, _fizzbuzz) {
"use strict";

_fooBar = babelHelpers.interopRequireDefault(_fooBar);
Expand Down
2 changes: 1 addition & 1 deletion ...sform-modules-umd/test/fixtures/loose/imports-exact-globals-true-with-overrides/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(global.fooBAR, global.mylib.fooBar, global.fizz.buzz);
global.input = mod.exports;
}
})(this, function (_fooBar, _fooBar2, _fizzbuzz) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_fooBar, _fooBar2, _fizzbuzz) {
"use strict";

_fooBar = babelHelpers.interopRequireDefault(_fooBar);
Expand Down
2 changes: 1 addition & 1 deletion ...bel-plugin-transform-modules-umd/test/fixtures/loose/imports-exact-globals-true/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(global.fooBar, global.mylibFooBar, global.fizzbuzz);
global.input = mod.exports;
}
})(this, function (_fooBar, _fooBar2, _fizzbuzz) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_fooBar, _fooBar2, _fizzbuzz) {
"use strict";

_fooBar = babelHelpers.interopRequireDefault(_fooBar);
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-transform-modules-umd/test/fixtures/loose/imports-glob/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(global.foo);
global.input = mod.exports;
}
})(this, function (foo) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (foo) {
"use strict";

foo = babelHelpers.interopRequireWildcard(foo);
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-transform-modules-umd/test/fixtures/loose/imports-mixing/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(global.foo);
global.input = mod.exports;
}
})(this, function (_foo) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_foo) {
"use strict";

_foo = babelHelpers.interopRequireWildcard(_foo);
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-transform-modules-umd/test/fixtures/loose/imports-named/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(global.foo);
global.input = mod.exports;
}
})(this, function (_foo) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_foo) {
"use strict";

_foo.bar;
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-transform-modules-umd/test/fixtures/loose/imports/output.js
View file
Open in desktop
Expand Up @@ -10,6 +10,6 @@
factory(global.foo, global.fooBar, global.fooBar);
global.input = mod.exports;
}
})(this, function (_foo, _fooBar, _fooBar2) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_foo, _fooBar, _fooBar2) {
"use strict";
});
2 changes: 1 addition & 1 deletion ...m-modules-umd/test/fixtures/loose/module-id-with-overridden-global-in-namespace/output.js
View file
Open in desktop
Expand Up @@ -11,7 +11,7 @@
global.foo = global.foo || {};
global.foo.bar = mod.exports;
}
})(this, function (_exports) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_exports) {
"use strict";

_exports.__esModule = true;
Expand Down
2 changes: 1 addition & 1 deletion ...d/test/fixtures/loose/module-id-with-overridden-global-in-very-nested-namespace/output.js
View file
Open in desktop
Expand Up @@ -13,7 +13,7 @@
global.foo.bar.baz = global.foo.bar.baz || {};
global.foo.bar.baz.qux = mod.exports;
}
})(this, function (_exports) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_exports) {
"use strict";

_exports.__esModule = true;
Expand Down
2 changes: 1 addition & 1 deletion ...ugin-transform-modules-umd/test/fixtures/loose/module-id-with-overridden-global/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(mod.exports);
global.baz = mod.exports;
}
})(this, function (_exports) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_exports) {
"use strict";

_exports.__esModule = true;
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-transform-modules-umd/test/fixtures/loose/module-id/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory();
global.MyLib = mod.exports;
}
})(this, function () {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function () {
"use strict";

foobar();
Expand Down
2 changes: 1 addition & 1 deletion ...in-transform-modules-umd/test/fixtures/loose/module-name-with-overridden-global/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(mod.exports);
global.looseModuleNameWithOverriddenGlobalInput = mod.exports;
}
})(this, function (_exports) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_exports) {
"use strict";

_exports.__esModule = true;
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-transform-modules-umd/test/fixtures/loose/module-name/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory();
global.looseModuleNameInput = mod.exports;
}
})(this, function () {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function () {
"use strict";

foobar();
Expand Down
2 changes: 1 addition & 1 deletion ...ages/babel-plugin-transform-modules-umd/test/fixtures/loose/non-default-imports/output.js
View file
Open in desktop
Expand Up @@ -10,6 +10,6 @@
factory(global.render);
global.input = mod.exports;
}
})(this, function (_render) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_render) {
"use strict";
});
2 changes: 1 addition & 1 deletion ...ges/babel-plugin-transform-modules-umd/test/fixtures/loose/override-export-name/output.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
factory(mod.exports);
global.input = mod.exports;
}
})(this, function (_exports) {
})(typeof globalThis === "object" ? globalThis : typeof self === "object" ? self : this, function (_exports) {
"use strict";

_exports.__esModule = true;
Expand Down