Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added check to disallow super.private variable access and test case added #10472

Merged
merged 7 commits into from Sep 20, 2019
Merged

added check to disallow super.private variable access and test case added #10472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4c4f7ac
:rocket: added check to disallow super.private variable access and te…
vivek12345 Sep 20, 2019
2309738
:recycle: change the other linting change back to how it was
vivek12345 Sep 20, 2019
5df46b6
:recycle: change the other linting change back to how it was
vivek12345 Sep 20, 2019
a40173c
:recycle: added newline at the end test output.json file
vivek12345 Sep 20, 2019
762e92b
:recycle: changed the linting style to the way it was
vivek12345 Sep 20, 2019
4cd44fa
:recycle: updated error message, removed super private member access …
vivek12345 Sep 20, 2019
65f596a
:recycle: added newline in output.json
vivek12345 Sep 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/babel-parser/src/parser/expression.js
View file
Open in desktop
Expand Up @@ -655,6 +655,12 @@ export default class ExpressionParser extends LValParser {
node.object = base;
node.property = this.parseMaybePrivateName();
node.computed = false;
if (
node.property.type === "PrivateName" &&
node.object.type === "Super"
) {
this.raise(startPos, "Private fields can't be accessed on super");
}
if (state.optionalChainMember) {
node.optional = false;
return this.finishNode(node, "OptionalMemberExpression");
Expand Down
7 changes: 7 additions & 0 deletions .../test/fixtures/experimental/class-private-properties/super-private-member-access/input.js
View file
Open in desktop
@@ -0,0 +1,7 @@
class A extends B {
#x;

method() {
super.#x;
}
}
6 changes: 6 additions & 0 deletions ...t/fixtures/experimental/class-private-properties/super-private-member-access/options.json
View file
Open in desktop
@@ -0,0 +1,6 @@
{
"plugins": [
"classPrivateProperties"
],
"throws": "Private fields can't be accessed on super (5:4)"
}
1 change: 0 additions & 1 deletion scripts/tests/flow/flow_tests_whitelist.txt
View file
Open in desktop
Expand Up @@ -19,7 +19,6 @@ class_properties/migrated_0021.js
class_properties/migrated_0026.js
decorators/migrated_0003.js
private_class_properties/multiple.js
private_class_properties/super.js
private_class_properties/getter_and_field.js
private_class_properties/getter_duplicate.js
private_class_properties/setter_and_field.js
Expand Down
4 changes: 0 additions & 4 deletions scripts/tests/test262/test262_whitelist.txt
View file
Open in desktop
Expand Up @@ -98,8 +98,6 @@ language/expressions/class/elements/syntax/early-errors/invalid-names/method-out
language/expressions/class/elements/syntax/early-errors/invalid-names/method-outter-member-expression-bad-reference.js(strict mode)
language/expressions/class/elements/syntax/early-errors/invalid-names/method-outter-member-expression-this.js(default)
language/expressions/class/elements/syntax/early-errors/invalid-names/method-outter-member-expression-this.js(strict mode)
language/expressions/class/elements/syntax/early-errors/super-private-access-invalid.js(default)
language/expressions/class/elements/syntax/early-errors/super-private-access-invalid.js(strict mode)
language/expressions/object/method-definition/private-name-early-error-async-gen-inside-class.js(default)
language/expressions/object/method-definition/private-name-early-error-async-gen-inside-class.js(strict mode)
language/expressions/object/method-definition/private-name-early-error-gen-inside-class.js(default)
Expand Down Expand Up @@ -282,8 +280,6 @@ language/statements/class/elements/syntax/early-errors/invalid-names/method-outt
language/statements/class/elements/syntax/early-errors/invalid-names/method-outter-member-expression-bad-reference.js(strict mode)
language/statements/class/elements/syntax/early-errors/invalid-names/method-outter-member-expression-this.js(default)
language/statements/class/elements/syntax/early-errors/invalid-names/method-outter-member-expression-this.js(strict mode)
language/statements/class/elements/syntax/early-errors/super-private-access-invalid.js(default)
language/statements/class/elements/syntax/early-errors/super-private-access-invalid.js(strict mode)
language/statements/for-in/dstr/array-rest-before-elision.js(default)
language/statements/for-in/dstr/array-rest-before-elision.js(strict mode)
language/statements/for-in/dstr/array-rest-elision-invalid.js(default)
Expand Down