Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[parser] Invalid NonOctal Decimal #10467

Merged
merged 12 commits into from Sep 23, 2019
Merged

[parser] Invalid NonOctal Decimal #10467

merged 12 commits into from Sep 23, 2019

Commits on Sep 23, 2019

  1. Add test

    @zant @nicolo-ribaudo
    zant authored and nicolo-ribaudo committed Sep 23, 2019
    Copy the full SHA
    a4bcbaf View commit details
    Browse the repository at this point in the history

  2. Add nonOctalDecimal verification

    @zant @nicolo-ribaudo
    zant authored and nicolo-ribaudo committed Sep 23, 2019
    Copy the full SHA
    2ac7281 View commit details
    Browse the repository at this point in the history

  3. Update regex and code style

    @zant @nicolo-ribaudo
    zant authored and nicolo-ribaudo committed Sep 23, 2019
    Copy the full SHA
    36b23ff View commit details
    Browse the repository at this point in the history

  4. Refactor non octal detection

    @zant @nicolo-ribaudo
    zant authored and nicolo-ribaudo committed Sep 23, 2019
    Copy the full SHA
    6bf61b6 View commit details
    Browse the repository at this point in the history

  5. Add numeric separator test

    @zant @nicolo-ribaudo
    zant authored and nicolo-ribaudo committed Sep 23, 2019
    Copy the full SHA
    63288b3 View commit details
    Browse the repository at this point in the history

  6. Disallow numeric separators in non octals

    @zant @nicolo-ribaudo
    zant authored and nicolo-ribaudo committed Sep 23, 2019
    Copy the full SHA
    ad99d8d View commit details
    Browse the repository at this point in the history

  7. Update whitelist

    @zant @nicolo-ribaudo
    zant authored and nicolo-ribaudo committed Sep 23, 2019
    Copy the full SHA
    9c26846 View commit details
    Browse the repository at this point in the history

  8. Better test naming

    @zant @nicolo-ribaudo
    zant authored and nicolo-ribaudo committed Sep 23, 2019
    Copy the full SHA
    dbaf284 View commit details
    Browse the repository at this point in the history

  9. Disallow numeric separators in non oct for all numbers

    @zant @nicolo-ribaudo
    zant authored and nicolo-ribaudo committed Sep 23, 2019
    Copy the full SHA
    a4c9bcf View commit details
    Browse the repository at this point in the history

  10. Specific error above the general error

    @zant @nicolo-ribaudo
    zant authored and nicolo-ribaudo committed Sep 23, 2019
    Copy the full SHA
    ae6025e View commit details
    Browse the repository at this point in the history

  11. Add test for invalid leading zero in num separator

    @zant @nicolo-ribaudo
    zant authored and nicolo-ribaudo committed Sep 23, 2019
    Copy the full SHA
    4b8e265 View commit details
    Browse the repository at this point in the history

  12. Add start position to error

    @zant @nicolo-ribaudo
    zant authored and nicolo-ribaudo committed Sep 23, 2019
    Copy the full SHA
    5283e6c View commit details
    Browse the repository at this point in the history