Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): correct typescript function headers #10404

Closed
wants to merge 2 commits into from
Closed

fix(types): correct typescript function headers #10404

wants to merge 2 commits into from

Commits on Sep 6, 2019

  1. fix(types): correct typescript function headers 

    Flow maybe types state;

> Maybe types accept the provided type as well as null or undefined. So ?number would mean number, null, or undefined.

So in this case, explicitly allow the type, null, or undefined in the
typescript definition.

Fixes #10403
    @matt-forster
    matt-forster committed Sep 6, 2019
    Copy the full SHA
    6be4ccc View commit details
    Browse the repository at this point in the history

  2. chore(types): disable eslint on function definition 

    precedent found on L149
    @matt-forster
    matt-forster committed Sep 6, 2019
    Copy the full SHA
    e72d9b1 View commit details
    Browse the repository at this point in the history