fix object rest in array pattern

[tanhauhau]

Q	A
Fixed Issues?	Fixes #7215, Fixes #10257
Patch: Bug Fix?	👍
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?	Yes
Documentation PR Link
Any Dependency Changes?
License	MIT

Edit by @JLHwung : Replace Fixes #7215, #10257 by Fixes #7215, Fixes #10257.

[babel-bot]

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11525/

[JLHwung]

@tanhauhau Could you rebase on the master branch? The linting errors have been fixed.

[JLHwung]

nit: prefer early return here for less nested blocks, and more effective diffs 🤦‍♂️.

[JLHwung]

Could you change Fixed Issues to

Fixes #7215, Fixes #10257

I don't think GitHub supports Fixes comma separated issues.

[hzoo]

Yeah @JLHwung is correct, it's required to put a word after for each number https://help.github.com/en/articles/closing-issues-using-keywords for ref!

[nicolo-ribaudo]

Shouldn't this be restElement.stop()?

[tanhauhau]

if i understand correctly, restElement.stop() will stop the traversing into restElement but continue on siblings, but path.stop() will stop the entire visitRestElements traversal?

[nicolo-ribaudo]

That should be the difference between .skip() and .stop(). path is not generated by visitElemenrs: you should use it when you want to stop the traversal which provided it.

[tanhauhau]

oh. understood.

I found out that this line was copied over from

babel/packages/babel-plugin-proposal-object-rest-spread/src/index.js

Lines 31 to 38 in 088d220

	function hasRestElement(path) {
	let foundRestElement = false;
	visitRestElements(path, () => {
	foundRestElement = true;
	path.stop();
	});
	return foundRestElement;
	}

does this means that this shouldnt use path.stop() either?

[nicolo-ribaudo]

Yeah, that looks like an error