Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: normalize sourcemap sources when generating from file name #10255

Closed
wants to merge 1 commit into from
Closed

fix: normalize sourcemap sources when generating from file name #10255

wants to merge 1 commit into from

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jul 23, 2019 •
edited

Q                       A
Fixed Issues? Fixes #10254
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Test passes on my local Windows build
Documentation PR Link
Any Dependency Changes?
License MIT

Replace in sourceFileName from \ to / when generating source maps.

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11214/

@JLHwung JLHwung added area: sourcemaps PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Jul 23, 2019
@JLHwung
Copy link
Contributor Author

JLHwung commented Sep 25, 2019

Close in favor of #10249.

@JLHwung JLHwung closed this Sep 25, 2019
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 26, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 26, 2019
@JLHwung JLHwung deleted the normalize-sourcemap-filename branch December 15, 2020 15:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
area: sourcemaps os: windows outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[babel-generator] should normalize sourceFileName when generating source maps
3 participants
@JLHwung @babel-bot @nicolo-ribaudo