Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix objectSpread2 backward compatibility #10170

Merged
merged 1 commit into from Jul 6, 2019
Merged

Fix objectSpread2 backward compatibility #10170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/babel-helpers/src/helpers.js
View file
Open in desktop
Expand Up @@ -406,7 +406,7 @@ helpers.objectSpread = helper("7.0.0-beta.0")`
}
`;

helpers.objectSpread2 = helper("7.0.0-beta.0")`
helpers.objectSpread2 = helper("7.5.0")`
import defineProperty from "defineProperty";

export default function _objectSpread2(target) {
Expand Down
8 changes: 7 additions & 1 deletion packages/babel-plugin-proposal-object-rest-spread/src/index.js
View file
Open in desktop
Expand Up @@ -452,7 +452,13 @@ export default declare((api, opts) => {
if (loose) {
helper = getExtendsHelper(file);
} else {
helper = file.addHelper("objectSpread2");
try {
helper = file.addHelper("objectSpread2");
} catch {
// objectSpread2 has been introduced in v7.5.0
// We have to maintain backward compatibility.
helper = file.addHelper("objectSpread");
}
}

path.replaceWith(t.callExpression(helper, args));
Expand Down