Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain typescript export-from-source #10167

Merged
merged 1 commit into from Jul 5, 2019

Conversation

Wolvereness
Copy link
Contributor

Q                       A
Fixed Issues? Fixes #10162
Patch: Bug Fix? yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This is (some of) @JLHwung's suggested changes with test case added (feel free to re-author if appropriate). In addition, a reported issue by @pixelass in the same comment thread now has a test case, but it is not a current bug, however was confirmed to have been one previously.

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11054/

Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test case when ExportSpecifier contains as?

import _bar from "./bar";
export { _bar as bar };

@nicolo-ribaudo nicolo-ribaudo added this to the v7.5.1 milestone Jul 5, 2019
@nicolo-ribaudo nicolo-ribaudo added i: regression PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Jul 5, 2019
@nicolo-ribaudo nicolo-ribaudo merged commit bff79e1 into babel:master Jul 5, 2019
@inje inje mentioned this pull request Jul 5, 2019
afc163 added a commit to ant-design/ant-design that referenced this pull request Jul 6, 2019
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-export statements are omitted from output using @babel/plugin-transform-typescript@7.5.0
5 participants