fix exportKind declaration in babel-types #10126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reExportAllDeclaration in babel-types
| @@ -260,6 +261,7 @@ defineType("ExportNamedDeclaration", { | |||
| validate: assertNodeType("StringLiteral"), | |||
| optional: true, | |||
| }, | |||
| exportKind: validateOptional(assertOneOf("type", "value", "let")), | |||
There was a problem hiding this comment.
found it in astexplorer when trying:
export let something=1
but can not reproduce it now… - will remove it
There was a problem hiding this comment.
Yeah, that should be a value export.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11000/ |
nicolo-ribaudo
added
pkg: types
PR: Bug Fix 🐛
nicolo-ribaudo
approved these changes
Jun 25, 2019
existentialism
approved these changes
Jun 25, 2019
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
babel-types:exportKindforExportNamedDeclarationexportKindtype forDeclareExportAllDeclarationbabel-parser:- updated types in to includeexportKind=let