fix destructuring rest with template literal #10013
Conversation
tanhauhau
commented
May 23, 2019
tanhauhau
commented
| Q | A |
|---|---|
| Fixed Issues? | Fixes #9834 |
| Patch: Bug Fix? | 👍 |
| Major: Breaking Change? | |
| Minor: New Feature? | |
| Tests Added + Pass? | Yes |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10847/ |
| @@ -0,0 +1,6 @@ | |||
| function testOmitProperties(initialObject, testKey) { | |||
| var { | |||
| [`${testKey}s`]: family, | |||
There was a problem hiding this comment.
What is it was ${i++}? It shouldn't increment it twice.
There was a problem hiding this comment.
apparently it's handled, updated test case to reflect the edge case.
interestingly, if the variable used, ie: testKey, the property key is pure. but if the variable is not defined, it is unpure.
There was a problem hiding this comment.
found this comment (#9416 (review)), wonder what is your plan, would like to work on it if I can
There was a problem hiding this comment.
found this comment (#9416 (review)), wonder what is your plan, would like to work on it if I can
I'll talk with the team to check if they are ok with it 👍
existentialism
added
the
PR: Bug Fix 🐛
|
thanks @tanhauhau! |
* fix destructuring rest with template literal * update test
lock
bot
added
the
outdated
