Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@babel/types wasn't released after being modified #9239

Closed
cameron-martin opened this issue Dec 26, 2018 · 3 comments · Fixed by #9245
Closed

@babel/types wasn't released after being modified #9239

cameron-martin opened this issue Dec 26, 2018 · 3 comments · Fixed by #9245
Assignees
Labels
area: publishing process i: bug outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Comments

@cameron-martin
Copy link
Contributor

Bug Report

Current Behavior
#9110 modified the typescript generator for @babel/types. There have been several releases since this PR was merged (v7.2.3-v7.2.5). However, these versions were not released for @babel/types - the most recent release is still v7.2.2.

Expected behavior/code
I would expect a new version of @babel/types to be released after the typescript generator was modified.

@babel-bot
Copy link
Collaborator

Hey @cameron-martin! We really appreciate you taking the time to report an issue. The collaborators
on this project attempt to help as many people as possible, but we're a limited number of volunteers,
so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack
community
that typically always has someone willing to help. You can sign-up here
for an invite.

@cameron-martin
Copy link
Contributor Author

Presumably this is because the scripts that generate the type definitions live outside of the package directory and lerna is not detecting this package as changed since the last release.

If somebody can confirm that this is the issue, then I can send a PR to move the scripts into the package directory.

@nicolo-ribaudo
Copy link
Member

If somebody can confirm that this is the issue, then I can send a PR to move the scripts into the package directory.

Yes please!

cameron-martin added a commit to cameron-martin/babel that referenced this issue Dec 27, 2018
Fixes babel#9239, but only partially because the generators still import utils from outside the package directory.
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 9, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: publishing process i: bug outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
3 participants