Define default value for vars shadowing params #11307
Conversation
nicolo-ribaudo
added
PR: Bug Fix 🐛
| @@ -1,4 +1,3 @@ | |||
| import callDelegate from "@babel/helper-call-delegate"; | |||
There was a problem hiding this comment.
This is now unused and can be removed from the repo.
This prevents this plugin from running after the destructuring transform, which causes babel#11256
|
I ended up also pushing a workaround for #11256 (a fix would require major changes to how we handle the scope) |
| @@ -1,5 +1,5 @@ | |||
| function foo(a = 2) { | |||
| for (var a, i = 0; i < 1; i++); | |||
| expect(a).toBe(undefined); | |||
| expect(a).toBe(2); | |||
|
|
||
| for (let i = 0; i < params.length; i++) { | ||
| const param = params[i]; | ||
| let isSimpleParameterList = true; |
There was a problem hiding this comment.
What about
const isSimpleParameterList = params.every(param => param.isIdentifier());It will return true when params is empty.
| scope: scope, | ||
| stop: false, | ||
| needsOuterBinding: false, | ||
| shadowedParams: new Set(), |
There was a problem hiding this comment.
We can move shadowedParams out of state if we don't intend it accessed by visitIdentifier.
| @@ -0,0 +1,6 @@ | |||
| function test(date, defValue = 1) { | |||
There was a problem hiding this comment.
nit: lol they don't have to be date and defValue.
|
|
||
| const iifeVisitor = { | ||
| ReferencedIdentifier(path, state) { |
There was a problem hiding this comment.
I guess we can simplify to
const iifeVisitor = {
"ReferencedIdentifier|BindingIdentifier": visitIdentifier,
}If there is a BindingIdentifier in the function scope, it should not satisfy scope.getBinding(name) === state.scope.parent.getBinding(name) so essentially it will be noop.
| !isSafeBinding(scope, node) || | ||
| !isSafeBinding(state.scope, node) | ||
| name === "eval" || | ||
| (scope.getBinding(name) === state.scope.parent.getBinding(name) && |
There was a problem hiding this comment.
Isn't this just a !scope.hasOwnBinding check?
There was a problem hiding this comment.
Nope, state.scope does not equal to scope.
… ci] Co-Authored-By: Brian Ng <bng412@gmail.com>
github-actions
bot
added
the
outdated
The best way to handle params's horrible shadowing behavior is by... relying on it 😁