Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logic to insert parens in return statements with comments #11306

Merged
merged 1 commit into from Mar 21, 2020
Merged

Fix logic to insert parens in return statements with comments #11306

merged 1 commit into from Mar 21, 2020

Conversation

nicolo-ribaudo
Copy link
Member

Q                       A
Fixed Issues? Fixes #11304
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Wow, this was super hard to debug 😬

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: generator i: regression labels Mar 21, 2020
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Mar 21, 2020
Closed
1 task
@nicolo-ribaudo nicolo-ribaudo linked an issue Mar 21, 2020 that may be closed by this pull request
Regression in preset-react 7.9.x. #11305
Closed
1 task
existentialism
existentialism approved these changes Mar 21, 2020
View reviewed changes
Copy link
Member

@existentialism existentialism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow lol

@nicolo-ribaudo nicolo-ribaudo added this to the v7.9.3 milestone Mar 21, 2020
@nicolo-ribaudo nicolo-ribaudo merged commit b0315b8 into babel:master Mar 21, 2020
@redonkulus
Copy link

@nicolo-ribaudo when do you think this will be published?

@nicolo-ribaudo nicolo-ribaudo deleted the newline-after-comment-in-return branch March 21, 2020 22:47
@nicolo-ribaudo
Copy link
Member Author

As soon as #11307 is merged (I need another review).

It might get delayed at most to tomorrow morning in my timezone (central europe).

birdofpreyru added a commit to birdofpreyru/react-utils that referenced this pull request Mar 22, 2020
@birdofpreyru
Downgrades @babel/preset-react to v7.8.3
78e7027 
The current latest `@babel/preset-react@7.9.1` contains a bug which
breaks React components in obscure ways. It looks like the issue has
been reported already, and the fix is ready and will be released soon.

babel/babel#11305
babel/babel#11306
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Mar 22, 2020
Closed
1 task
@zombieJ
Copy link

zombieJ commented Mar 22, 2020

Seems #11307 merged. Is that possible to patch? : )

@nicolo-ribaudo
Copy link
Member Author

Published

@afc163 afc163 mentioned this pull request Mar 22, 2020
Closed
2 tasks
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 22, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@JLHwung JLHwung JLHwung approved these changes

Assignees
No one assigned
Labels
i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
v7.9.3
Development

Successfully merging this pull request may close these issues.

Regression in preset-react 7.9.x. // comments in anonymous functions break React code
5 participants
@nicolo-ribaudo @redonkulus @zombieJ @existentialism @JLHwung