Use the local version of babel in test262 job #10749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbhoosreddy
force-pushed
the
use-local-babel
branch
from
e6e2de4
to
65a046d
Compare
jbhoosreddy
changed the title
|
@nicolo-ribaudo this PR is also ready to go! 🕺 |
.circleci/config.yml
Outdated
| @@ -101,23 +101,25 @@ jobs: | |||
| - run: | |||
| name: Setup Test Runner | |||
| command: | | |||
| git clone --recurse-submodules https://github.com/babel/babel-test262-runner | |||
| git clone --recurse-submodules https://github.com/jbhoosreddy/babel-test262-runner | |||
nicolo-ribaudo
approved these changes
Nov 22, 2019
existentialism
approved these changes
Nov 22, 2019
|
@jbhoosreddy nice work! |
JLHwung
approved these changes
Nov 22, 2019
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2Raised in #10556 (review), this PR attempts to use a local copy of babel by directly referencing it instead of using
yarn linkto link all packages.Relates to: babel/babel-test262-runner#25
I didn't realize this before but using the local copy instead of the published packages means the the stack traces are much more usable, apparently!