Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add local babel workflow #25

Merged
merged 2 commits into from Nov 22, 2019
Merged

Add local babel workflow #25

merged 2 commits into from Nov 22, 2019

Conversation

jbhoosreddy
Copy link
Collaborator

@jbhoosreddy jbhoosreddy commented Nov 16, 2019 •
edited

Fixes #5

Summary of changes

  1. Now that we've hit a major milestone and we're actually running babel on CI, this is a necessary changeset to facilitate debugging of failing tests which will surely arise in the future.

This must be merged before babel/babel#10749.

@jbhoosreddy jbhoosreddy mentioned this pull request Nov 18, 2019
Closed
@jbhoosreddy
Copy link
Collaborator Author

let's hold off on landing this one.. I realized I can/should test it against the CI

@jbhoosreddy jbhoosreddy mentioned this pull request Nov 22, 2019
Merged
@jbhoosreddy
Copy link
Collaborator Author

Alright. @nicolo-ribaudo and @JLHwung this PR is ready to be merged. Tested against main repo. 💪

@nicolo-ribaudo nicolo-ribaudo merged commit 63bad42 into babel:master Nov 22, 2019
@jbhoosreddy jbhoosreddy deleted the local-babel branch November 22, 2019 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@JLHwung JLHwung Awaiting requested review from JLHwung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow testing a local copy of Babel
2 participants
@jbhoosreddy @nicolo-ribaudo