add more test cases for readonly

babel · Mar 12, 2019 · ff3a66e · ff3a66e
1 parent d16e51e
commit ff3a66e
Show file tree

Hide file tree

Showing 11 changed files with 186 additions and 6 deletions.
diff --git a/packages/babel-parser/src/plugins/typescript.js b/packages/babel-parser/src/plugins/typescript.js
@@ -710,9 +710,27 @@ export default (superClass: Class<Parser>): Class<Parser> =>
       this.expectContextual(operator);
       node.operator = operator;
       node.typeAnnotation = this.tsParseTypeOperatorOrHigher();
+
+      if (operator === "readonly") {
+        this.tsCheckTypeAnnotationForReadOnly(node);
+      }
+
       return this.finishNode(node, "TSTypeOperator");
     }
 
+    tsCheckTypeAnnotationForReadOnly(node: N.Node) {
+      switch (node.typeAnnotation.type) {
+        case "TSTupleType":
+        case "TSArrayType":
+          return;
+        default:
+          this.raise(
+            node.operator,
+            "'readonly' type modifier is only permitted on array and tuple literal types.",
+          );
+      }
+    }
+
     tsParseInferType(): N.TsInferType {
       const node = this.startNode();
       this.expectContextual("infer");

diff --git a/packages/babel-parser/test/fixtures/typescript/types/read-only-1/input.js b/packages/babel-parser/test/fixtures/typescript/types/read-only-1/input.js
@@ -0,0 +1 @@
+type T30 = readonly string;  // Error
diff --git a/packages/babel-parser/test/fixtures/typescript/types/read-only-1/options.json b/packages/babel-parser/test/fixtures/typescript/types/read-only-1/options.json
@@ -0,0 +1,7 @@
+{
+  "sourceType": "module",
+  "plugins": [
+    "typescript"
+  ],
+  "throws": "'readonly' type modifier is only permitted on array and tuple literal types. (1:NaN)"
+}
diff --git a/packages/babel-parser/test/fixtures/typescript/types/read-only-2/input.js b/packages/babel-parser/test/fixtures/typescript/types/read-only-2/input.js
@@ -0,0 +1 @@
+type T31 = readonly T;  // Error
diff --git a/packages/babel-parser/test/fixtures/typescript/types/read-only-2/options.json b/packages/babel-parser/test/fixtures/typescript/types/read-only-2/options.json
@@ -0,0 +1,7 @@
+{
+  "sourceType": "module",
+  "plugins": [
+    "typescript"
+  ],
+  "throws": "'readonly' type modifier is only permitted on array and tuple literal types. (1:NaN)"
+}
diff --git a/packages/babel-parser/test/fixtures/typescript/types/read-only-3/input.js b/packages/babel-parser/test/fixtures/typescript/types/read-only-3/input.js
@@ -0,0 +1 @@
+type T32 = readonly readonly string[];  // Error
diff --git a/packages/babel-parser/test/fixtures/typescript/types/read-only-3/options.json b/packages/babel-parser/test/fixtures/typescript/types/read-only-3/options.json
@@ -0,0 +1,7 @@
+{
+  "sourceType": "module",
+  "plugins": [
+    "typescript"
+  ],
+  "throws": "'readonly' type modifier is only permitted on array and tuple literal types. (1:NaN)"
+}
diff --git a/packages/babel-parser/test/fixtures/typescript/types/read-only-4/input.js b/packages/babel-parser/test/fixtures/typescript/types/read-only-4/input.js
@@ -0,0 +1 @@
+type T33 = readonly Array<string>;  // Error
diff --git a/packages/babel-parser/test/fixtures/typescript/types/read-only-4/options.json b/packages/babel-parser/test/fixtures/typescript/types/read-only-4/options.json
@@ -0,0 +1,7 @@
+{
+  "sourceType": "module",
+  "plugins": [
+    "typescript"
+  ],
+  "throws": "'readonly' type modifier is only permitted on array and tuple literal types. (1:NaN)"
+}
diff --git a/packages/babel-parser/test/fixtures/typescript/types/type-operator/input.js b/packages/babel-parser/test/fixtures/typescript/types/type-operator/input.js
@@ -1,3 +1,4 @@
 let x: keyof T;
 let y: unique symbol;
 let z: readonly number[];
+let z1: readonly [number, number];
diff --git a/packages/babel-parser/test/fixtures/typescript/types/type-operator/output.json b/packages/babel-parser/test/fixtures/typescript/types/type-operator/output.json
@@ -1,29 +1,29 @@
 {
   "type": "File",
   "start": 0,
-  "end": 63,
+  "end": 98,
   "loc": {
     "start": {
       "line": 1,
       "column": 0
     },
     "end": {
-      "line": 3,
-      "column": 25
+      "line": 4,
+      "column": 34
     }
   },
   "program": {
     "type": "Program",
     "start": 0,
-    "end": 63,
+    "end": 98,
     "loc": {
       "start": {
         "line": 1,
         "column": 0
       },
       "end": {
-        "line": 3,
-        "column": 25
+        "line": 4,
+        "column": 34
       }
     },
     "sourceType": "module",
@@ -351,6 +351,135 @@
           }
         ],
         "kind": "let"
+      },
+      {
+        "type": "VariableDeclaration",
+        "start": 64,
+        "end": 98,
+        "loc": {
+          "start": {
+            "line": 4,
+            "column": 0
+          },
+          "end": {
+            "line": 4,
+            "column": 34
+          }
+        },
+        "declarations": [
+          {
+            "type": "VariableDeclarator",
+            "start": 68,
+            "end": 97,
+            "loc": {
+              "start": {
+                "line": 4,
+                "column": 4
+              },
+              "end": {
+                "line": 4,
+                "column": 33
+              }
+            },
+            "id": {
+              "type": "Identifier",
+              "start": 68,
+              "end": 97,
+              "loc": {
+                "start": {
+                  "line": 4,
+                  "column": 4
+                },
+                "end": {
+                  "line": 4,
+                  "column": 33
+                },
+                "identifierName": "z1"
+              },
+              "name": "z1",
+              "typeAnnotation": {
+                "type": "TSTypeAnnotation",
+                "start": 70,
+                "end": 97,
+                "loc": {
+                  "start": {
+                    "line": 4,
+                    "column": 6
+                  },
+                  "end": {
+                    "line": 4,
+                    "column": 33
+                  }
+                },
+                "typeAnnotation": {
+                  "type": "TSTypeOperator",
+                  "start": 72,
+                  "end": 97,
+                  "loc": {
+                    "start": {
+                      "line": 4,
+                      "column": 8
+                    },
+                    "end": {
+                      "line": 4,
+                      "column": 33
+                    }
+                  },
+                  "operator": "readonly",
+                  "typeAnnotation": {
+                    "type": "TSTupleType",
+                    "start": 81,
+                    "end": 97,
+                    "loc": {
+                      "start": {
+                        "line": 4,
+                        "column": 17
+                      },
+                      "end": {
+                        "line": 4,
+                        "column": 33
+                      }
+                    },
+                    "elementTypes": [
+                      {
+                        "type": "TSNumberKeyword",
+                        "start": 82,
+                        "end": 88,
+                        "loc": {
+                          "start": {
+                            "line": 4,
+                            "column": 18
+                          },
+                          "end": {
+                            "line": 4,
+                            "column": 24
+                          }
+                        }
+                      },
+                      {
+                        "type": "TSNumberKeyword",
+                        "start": 90,
+                        "end": 96,
+                        "loc": {
+                          "start": {
+                            "line": 4,
+                            "column": 26
+                          },
+                          "end": {
+                            "line": 4,
+                            "column": 32
+                          }
+                        }
+                      }
+                    ]
+                  }
+                }
+              }
+            },
+            "init": null
+          }
+        ],
+        "kind": "let"
       }
     ],
     "directives": []