Address feedback

babel · May 1, 2020 · e91c078 · e91c078
1 parent ed4c400
commit e91c078
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 8 deletions.
diff --git a/...t/babel-eslint-plugin-internal/.npmignore → ...nt-plugin-development-internal/.npmignore b/...t/babel-eslint-plugin-internal/.npmignore → ...nt-plugin-development-internal/.npmignore
diff --git a/...nt/babel-eslint-plugin-internal/README.md → ...int-plugin-development-internal/README.md b/...nt/babel-eslint-plugin-internal/README.md → ...int-plugin-development-internal/README.md
diff --git a/...babel-eslint-plugin-internal/package.json → ...-plugin-development-internal/package.json b/...babel-eslint-plugin-internal/package.json → ...-plugin-development-internal/package.json
@@ -1,12 +1,12 @@
 {
-  "name": "@babel/eslint-plugin-internal",
+  "name": "@babel/eslint-plugin-development-internal",
   "version": "0.0.0",
   "description": "The Babel Team's ESLint custom rules plugin. Since it's internal, it might not respect semver.",
   "main": "lib/index.js",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/babel/babel.git",
-    "directory": "eslint/babel-eslint-plugin-internal"
+    "directory": "eslint/babel-eslint-plugin-development-internal"
   },
   "keywords": [
     "babel",
@@ -24,7 +24,7 @@
   "bugs": {
     "url": "https://github.com/babel/babel/issues"
   },
-  "homepage": "https://github.com/babel/babel/tree/master/eslint/babel-eslint-plugin-internal",
+  "homepage": "https://github.com/babel/babel/tree/master/eslint/babel-eslint-plugin-development-internal",
   "peerDependencies": {
     "@babel/eslint-parser": "0.0.0",
     "eslint": ">=6.0.0"

diff --git a/...babel-eslint-plugin-internal/src/index.js → ...-plugin-development-internal/src/index.js b/...babel-eslint-plugin-internal/src/index.js → ...-plugin-development-internal/src/index.js
diff --git a/...-internal/src/rules/dry-error-messages.js → ...-internal/src/rules/dry-error-messages.js b/...-internal/src/rules/dry-error-messages.js → ...-internal/src/rules/dry-error-messages.js
@@ -108,12 +108,10 @@ export default {
           }
         }
       },
-      "ThrowStatement[argument.type='CallExpression'] [callee.type='MemberExpression']"(
-        node,
-      ) {
+      "ThrowStatement > CallExpression[callee.type='MemberExpression']"(node) {
         if (
-          node.callee.object?.type !== "ThisExpression" ||
-          node.callee.property?.name !== "raise"
+          node.callee.object.type !== "ThisExpression" ||
+          node.callee.property.name !== "raise"
         ) {
           return;
         }

diff --git a/...internal/test/rules/dry-error-messages.js → ...internal/test/rules/dry-error-messages.js b/...internal/test/rules/dry-error-messages.js → ...internal/test/rules/dry-error-messages.js
@@ -17,6 +17,10 @@ ruleTester.run("dry-error-messages", rule, {
     "this.raise(() => { throw new Error('Uh oh') });",
     "throw new Error('Uh oh')",
     "throw this.createError('Uh oh')",
+    "throw this.error",
+    "throw this.raise",
+    "throw obj.error",
+    "throw obj.raise",
     {
       filename: FILENAME,
       code: